suddendust commented on PR #14348:
URL: https://github.com/apache/pinot/pull/14348#issuecomment-2521143036
>Wondering why you don't need to explicitly specify pattern for other gauges?
@Jackie-Jiang We do have patterns for gauges too, ex:
```
- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ServerMetrics\",
name=\"pinot\\.server\\.(realtimeSegmentNumPartitions|luceneIndexingDelayMs|luceneIndexingDelayDocs)\\.(([^.]+)\\.)?([^.]*)\"><>(\\w+)"
name: "pinot_server_$1_$5"
cache: true
labels:
database: "$3"
table: "$2$4"
```
In this, the gauge name comes before the table name. Similarly, we have
regexps that match all the gauges.
>Is our test good enough to catch all metrics?
It iterates through all the metrics (using data providers) so it is good
enough.
>Also, do you see a way to make them consistent?
We'll mostly have to fix the gauge naming convention and then change the
corresponding regexps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
