rfscholte commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1753669384
##########
pinot-spi/pom.xml:
##########
@@ -36,6 +36,82 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.7.1</version>
+ <executions>
+ <execution>
+ <id>copy-pinot-plugins</id>
+ <!-- The org.apache.pinot.spi.plugin.PluginManagerTest has tests
that requires plugin jars.
+ These jars could have been added to
src/test/resources/plugins, but that would increase the size of
+ source repository a lot. Instead, let Maven download these
jars and put them at the expected location.
+ -->
+ <phase>generate-test-resources</phase>
+ <goals>
+ <goal>copy</goal>
+ </goals>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-dropwizard</artifactId>
+ <version>0.10.0</version>
Review Comment:
We need a stable jar from which we exactly know which class are there and
which one aren't. That's why we cannot and shound not use the latest snapshot
here. Suppose we did that, there could be a situation where a change to
pinot-dropwizard could make a test of pinot-spi fail. That is really unexpected!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
