Jackie-Jiang commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1752778957
##########
pinot-spi/pom.xml:
##########
@@ -36,6 +36,82 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.7.1</version>
+ <executions>
+ <execution>
+ <id>copy-pinot-plugins</id>
+ <!-- The org.apache.pinot.spi.plugin.PluginManagerTest has tests
that requires plugin jars.
+ These jars could have been added to
src/test/resources/plugins, but that would increase the size of
+ source repository a lot. Instead, let Maven download these
jars and put them at the expected location.
+ -->
+ <phase>generate-test-resources</phase>
+ <goals>
+ <goal>copy</goal>
+ </goals>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-dropwizard</artifactId>
+ <version>0.10.0</version>
Review Comment:
Can we avoid hard code versions for these libraries? Also, why is the
version `0.10.0`?
##########
pinot-spi/pom.xml:
##########
@@ -36,6 +36,82 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.7.1</version>
Review Comment:
We shouldn't need to pin version for this plugin
##########
pinot-spi/pom.xml:
##########
@@ -36,6 +36,82 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.7.1</version>
+ <executions>
+ <execution>
+ <id>copy-pinot-plugins</id>
+ <!-- The org.apache.pinot.spi.plugin.PluginManagerTest has tests
that requires plugin jars.
+ These jars could have been added to
src/test/resources/plugins, but that would increase the size of
+ source repository a lot. Instead, let Maven download these
jars and put them at the expected location.
+ -->
+ <phase>generate-test-resources</phase>
+ <goals>
+ <goal>copy</goal>
+ </goals>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-dropwizard</artifactId>
+ <version>0.10.0</version>
+ <classifier>shaded</classifier>
+
<outputDirectory>${project.build.testOutputDirectory}/plugins/pinot-dropwizard</outputDirectory>
+ </artifactItem>
+ <artifactItem>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-yammer</artifactId>
+ <version>0.10.0</version>
+ <classifier>shaded</classifier>
+
<outputDirectory>${project.build.testOutputDirectory}/plugins/pinot-yammer</outputDirectory>
+ </artifactItem>
+ <artifactItem>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-yammer</artifactId>
+ <version>0.10.0</version>
+ <classifier>shaded</classifier>
+
<outputDirectory>${project.build.testOutputDirectory}/plugins/pinot-shaded-yammer</outputDirectory>
+ </artifactItem>
+ <artifactItem>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ <version>2.11.0</version>
Review Comment:
Are we able to use the version defined in the root POM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
