rfscholte commented on code in PR #13845:
URL: https://github.com/apache/pinot/pull/13845#discussion_r1725354173
##########
pinot-spi/pom.xml:
##########
@@ -36,6 +36,38 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.7.1</version>
+ <executions>
+ <execution>
+ <id>copy-pinot-plugins</id>
+ <phase>process-test-resources</phase>
+ <goals>
+ <goal>copy</goal>
+ </goals>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-dropwizard</artifactId>
+ <version>0.10.0</version>
Review Comment:
I prefer it like this, because it makes the test more solid. In case
pinot-dropwizard would change its content or would be removed, this test would
suddenly fail. So that means that the developer working on pinot-dropwizard
breaks tests of pinot-spi!?!? That is so unexpected (the otherway around could
make sense: changes in pinot-spi could break plugins)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
