gortiz commented on code in PR #13845:
URL: https://github.com/apache/pinot/pull/13845#discussion_r1725125502
##########
pinot-spi/pom.xml:
##########
@@ -36,6 +36,38 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.7.1</version>
+ <executions>
+ <execution>
+ <id>copy-pinot-plugins</id>
+ <phase>process-test-resources</phase>
+ <goals>
+ <goal>copy</goal>
+ </goals>
Review Comment:
nit: I think this is a good idea but probably devs are not going to
understand on a first read why this plugin is necessary.
Can you add a comment here saying that PluginManagerTest requires these
resources and we decided to copy them at build time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
