rfscholte commented on code in PR #13845:
URL: https://github.com/apache/pinot/pull/13845#discussion_r1735891162
##########
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##########
@@ -41,10 +51,18 @@ public class PluginManager {
public static final String PLUGINS_DIR_PROPERTY_NAME = "plugins.dir";
public static final String PLUGINS_INCLUDE_PROPERTY_NAME = "plugins.include";
+ public static final String PLUGINS_LOADER_LEGACY_PROPERTY_NAME =
"pinot.plugins.loader.legacy";
+ public static final String PLUGINS_LOADER_LEGACY_DEFAULT = "false";
Review Comment:
If we make legacy the default, I wonder if anyone dares to switch to plexus
classworld, even though classloader issues keep happening. Instead I propose to
make plexus classworlds behave more like its current behavior. i.e. having
access to all classes (like now) but loading them in the expected order. In
other words: make them unlimited. The switch to limited as default is smaller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
