gortiz commented on code in PR #13845:
URL: https://github.com/apache/pinot/pull/13845#discussion_r1725136964
##########
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##########
@@ -111,13 +122,30 @@ public class PluginManager {
}
};
- private Map<Plugin, PluginClassLoader> _registry = new HashMap<>();
+ private final ClassWorld _classWorld;
+ private final Map<Plugin, PluginClassLoader> _registry;
+
private String _pluginsDirectories;
private String _pluginsInclude;
private boolean _initialized = false;
- private PluginManager() {
- _registry.put(new Plugin(DEFAULT_PLUGIN_NAME),
createClassLoader(Collections.emptyList()));
+ PluginManager() {
+ if (useLegacyPluginClassloader()) {
Review Comment:
Can we add a log (in info level) saying whether we are using legacy mode or
not? That is the kind of log that help a lot when having issues in production 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
