rfscholte commented on code in PR #13845:
URL: https://github.com/apache/pinot/pull/13845#discussion_r1723319667
##########
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##########
@@ -41,11 +47,16 @@ public class PluginManager {
public static final String PLUGINS_DIR_PROPERTY_NAME = "plugins.dir";
public static final String PLUGINS_INCLUDE_PROPERTY_NAME = "plugins.include";
+ public static final String PLUGINS_LOADER_LEGACY_PROPERTY_NAME =
"pinot.plugins.loader.legacy";
Review Comment:
I've introduced a system property to fall back to the original behavior. I
can imagine that some plugins rely on internal pinot-classes, which will now
fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
