gortiz commented on code in PR #13845:
URL: https://github.com/apache/pinot/pull/13845#discussion_r1735911607
##########
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##########
@@ -41,10 +51,18 @@ public class PluginManager {
public static final String PLUGINS_DIR_PROPERTY_NAME = "plugins.dir";
public static final String PLUGINS_INCLUDE_PROPERTY_NAME = "plugins.include";
+ public static final String PLUGINS_LOADER_LEGACY_PROPERTY_NAME =
"pinot.plugins.loader.legacy";
+ public static final String PLUGINS_LOADER_LEGACY_DEFAULT = "false";
Review Comment:
We are used to use flags to enable new features to be sure we do not affect
deployments where the flag is not set. I'm sure StarTree will use the new
system in their deployments (after testing it for a while), so I'm sure it is
going to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
