soumitra-st commented on code in PR #13361:
URL: https://github.com/apache/pinot/pull/13361#discussion_r1695692423
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCache.java:
##########
@@ -141,18 +143,18 @@ private Map<String, List<BrokerInstance>>
getTableToBrokersData() throws Excepti
private BrokerData getBrokerData(Map<String, List<BrokerInstance>>
responses) {
Set<String> brokers = new HashSet<>();
- Map<String, List<String>> tableToBrokersMap = new HashMap<>();
+ Map<String, List<BrokerInfo>> tableToBrokersMap = new HashMap<>();
Review Comment:
Can you elaborate the reason for moving from String to the BrokerInfo
object, is it to fix an existing bug? If it is, can you point to the testcase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
