vrajat commented on code in PR #13361:
URL: https://github.com/apache/pinot/pull/13361#discussion_r1696338894
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCache.java:
##########
@@ -141,18 +143,18 @@ private Map<String, List<BrokerInstance>>
getTableToBrokersData() throws Excepti
private BrokerData getBrokerData(Map<String, List<BrokerInstance>>
responses) {
Set<String> brokers = new HashSet<>();
- Map<String, List<String>> tableToBrokersMap = new HashMap<>();
+ Map<String, List<BrokerInfo>> tableToBrokersMap = new HashMap<>();
Review Comment:
I made the change to make `BrokerSelector` more reusable. BrokerSelectors
are used in the client, controller and now in Startree's proxy. The network
address are generated in different ways. The client and proxy can reuse the
ports from the metadata in Helix/ZK. However the controller may have to use the
port specified in a different config. `BrokerInfo` maintains the metadata in
its canonical form so that module can use the metadata in the way it works for
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
