vrajat commented on PR #13361: URL: https://github.com/apache/pinot/pull/13361#issuecomment-2210174199
I think `DynamicBrokerSelector` had a bug. It was returning a list of ZK servers in `DynamicBrokerSelector.getBrokers()`. The test also used the list of ZK servers as the expected results. I checked other implementations and they do return broker information and not ZK server information. So I have fixed it here: https://github.com/apache/pinot/pull/13361/files#diff-9aba27bda6f4d7695e6032c5354a3d249fb4d10f7c23c8ea3528d1fc4d412dcfR146 Can you please verify? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
