soumitra-st commented on code in PR #13361:
URL: https://github.com/apache/pinot/pull/13361#discussion_r1695691915
##########
pinot-common/src/main/java/org/apache/pinot/common/broker/BrokerSelectorUtils.java:
##########
@@ -36,8 +35,9 @@ private BrokerSelectorUtils() {
* @param brokerData: map holding data for table hosting on brokers.
* @return list of common brokers hosting all the tables.
*/
- public static List<String> getTablesCommonBrokers(List<String> tableNames,
Map<String, List<String>> brokerData) {
- List<List<String>> tablesBrokersList = new ArrayList<>();
+ public static List<BrokerInfo> getTablesCommonBrokers(List<String>
tableNames,
+ Map<String, List<BrokerInfo>> brokerData) {
+ List<List<BrokerInfo>> tablesBrokersList = new ArrayList<>();
Review Comment:
Multiple tables may be in the same tenant. The better way is to get to the
set of tenants from the list of tables and then find the common brokers across
these tenants. If there is a way to get to tenants from tables, let's do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
