soumitra-st commented on code in PR #13361: URL: https://github.com/apache/pinot/pull/13361#discussion_r1694258936
########## pinot-common/src/main/java/org/apache/pinot/common/broker/BrokerInfoSelector.java: ########## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.broker; + +import java.util.List; +import java.util.stream.Collectors; +import javax.annotation.Nullable; + + +public abstract class BrokerInfoSelector implements BrokerSelector { + + protected final boolean _preferTlsPort; Review Comment: I am not getting the prefer tls port logic in this PR. IMO, tls vs not is decided somewhere else, and this logic should not worry if the the port is tls. Moreover, the previous code didn't worry about this, so why now? I am missing something here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
