soumitra-st commented on code in PR #13361: URL: https://github.com/apache/pinot/pull/13361#discussion_r1694257441
########## pinot-common/src/main/java/org/apache/pinot/common/broker/BrokerInfo.java: ########## @@ -0,0 +1,92 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.broker; + +import java.util.Objects; + + +/** + * Store ID and network information about Brokers required by components that have to select a broker. + */ +public class BrokerInfo { + private final String _instanceId; + private final String _hostname; + private final int _port; + private final int _tlsPort; + + public BrokerInfo(String instanceId, String hostname, int port, int tlsPort) { + _instanceId = instanceId; + _hostname = hostname; + _port = port; + _tlsPort = tlsPort; + } + + public BrokerInfo(String instanceId, String hostname, int port) { + _instanceId = instanceId; + _hostname = hostname; + _port = port; + _tlsPort = -1; + } + + public BrokerInfo(String hostname, int port) { + // If an instance ID is not specified, then use host:port as the identifier. + _instanceId = hostname + ":" + port; + _hostname = hostname; + _port = port; + _tlsPort = -1; + } + + public String getInstanceId() { + return _instanceId; + } + + public String getHostname() { + return _hostname; + } + + public int getPort() { + return _port; + } + + public int getTlsPort() { + return _tlsPort; + } + + public String getHostPort(boolean preferTlsPort) { Review Comment: This is error prone. How can a consumer decide whether to use tls or not at this level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
