tibrewalpratik17 commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1533040292
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaMessageBatch.java:
##########
@@ -92,6 +92,11 @@ public StreamPartitionMsgOffset
getNextStreamPartitionMsgOffsetAtIndex(int index
return new LongMsgOffset(((KafkaStreamMessage)
_messageList.get(index)).getNextOffset());
}
+ @Override
+ public StreamPartitionMsgOffset getStreamPartitionMsgOffsetAtIndex(int
index) {
+ return new LongMsgOffset(((KafkaStreamMessage)
_messageList.get(index)).getOffset());
Review Comment:
For other stream types, I saw it uses the default method. I tried to
maintain consistency with what we were doing for `getNextOffset` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
