satishd commented on code in PR #12602: URL: https://github.com/apache/pinot/pull/12602#discussion_r1523138383
########## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ########## @@ -305,6 +305,7 @@ public void deleteSegmentFile() { private final StreamPartitionMsgOffset _latestStreamOffsetAtStartupTime; private final CompletionMode _segmentCompletionMode; + private final List<String> _filteredMessageOffsets = new ArrayList<>(); Review Comment: +1 to add that as a config with the default value being false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org