Jackie-Jiang commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1533054790
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java:
##########
@@ -104,6 +104,15 @@ default StreamPartitionMsgOffset
getNextStreamPartitionMsgOffsetAtIndex(int inde
return new LongMsgOffset(getNextStreamMessageOffsetAtIndex(index));
}
+ /**
+ * Returns the offset of this message.
+ * @param index
+ * @return
+ */
+ default StreamPartitionMsgOffset getStreamPartitionMsgOffsetAtIndex(int
index) {
+ return new LongMsgOffset(getMessageOffsetAtIndex(index));
Review Comment:
That is true, and I'm trying to make a PR to clean up these APIs. I'd also
suggest not adding new APIs for now.
@tibrewalpratik17 Is this change urgent? If it is not urgent, I'd like to
first clean up this interface, then you may use the new APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
