ankitsultana commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1526861926
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -597,6 +599,9 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
realtimeRowsDroppedMeter =
_serverMetrics.addMeteredTableValue(_clientId,
ServerMeter.REALTIME_ROWS_FILTERED,
reusedResult.getSkippedRowCount(), realtimeRowsDroppedMeter);
+ if (_trackFilteredMessageOffsets) {
+ _filteredMessageOffsets.add(messageOffset.toString());
Review Comment:
Why are we tracking individual offsets? Wouldn't tracking the number of
messages filtered be enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
