ankitsultana commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1527097742
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1743,6 +1752,12 @@ private void updateCurrentDocumentCountMetrics() {
rowsConsumed, consumedRate, _currentOffset, _numRowsConsumed,
_numRowsIndexed);
_lastConsumedCount = _numRowsConsumed;
_lastLogTime = now;
+ if (_filteredMessageOffsets.size() > 0) {
+ if (_trackFilteredMessageOffsets) {
+ _segmentLogger.info("Filtered events with offsets: {}",
_filteredMessageOffsets);
Review Comment:
if there are a lot of offsets, then the log line may become super high.
Maybe log a sublist of 5-10 elements if the length exceeds a certain threshold?
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1743,6 +1752,12 @@ private void updateCurrentDocumentCountMetrics() {
rowsConsumed, consumedRate, _currentOffset, _numRowsConsumed,
_numRowsIndexed);
_lastConsumedCount = _numRowsConsumed;
_lastLogTime = now;
+ if (_filteredMessageOffsets.size() > 0) {
+ if (_trackFilteredMessageOffsets) {
+ _segmentLogger.info("Filtered events with offsets: {}",
_filteredMessageOffsets);
Review Comment:
if there are a lot of offsets, then the log line may become super long.
Maybe log a sublist of 5-10 elements if the length exceeds a certain threshold?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
