tibrewalpratik17 commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1533058300
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java:
##########
@@ -104,6 +104,15 @@ default StreamPartitionMsgOffset
getNextStreamPartitionMsgOffsetAtIndex(int inde
return new LongMsgOffset(getNextStreamMessageOffsetAtIndex(index));
}
+ /**
+ * Returns the offset of this message.
+ * @param index
+ * @return
+ */
+ default StreamPartitionMsgOffset getStreamPartitionMsgOffsetAtIndex(int
index) {
+ return new LongMsgOffset(getMessageOffsetAtIndex(index));
Review Comment:
> @tibrewalpratik17 Is this change urgent? If it is not urgent, I'd like to
first clean up this interface, then you may use the new APIs
Sure can wait until your changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
