gortiz commented on PR #12343: URL: https://github.com/apache/pinot/pull/12343#issuecomment-1920737404
> When segment is dropped from server (due to rebalance or segment removal), TableDataManager.onConsumingToDropped() will be invoked via the helix state transition from CONSUMING to DROPPED That is correct. `TableDataManager.onConsumingToDropped()` is being called by `SegmentOnlineOfflineStateModelFactory.onBecomeDroppedFromConsuming`. But that is not the transition we do when rebalancing. In that case we call `SegmentOnlineOfflineStateModelFactory.onBecomeOfflineFromConsuming`, which does not call `TableDataManager.onConsumingToDropped()`. Do you suggest to add a call to `TableDataManager.onConsumingToDropped()` in `SegmentOnlineOfflineStateModelFactory.onBecomeOfflineFromConsuming`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
