siddharthteotia commented on code in PR #8720:
URL: https://github.com/apache/pinot/pull/8720#discussion_r879895566
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -218,11 +225,16 @@ public static class Broker {
public static final String CONFIG_OF_BROKER_GROUPBY_TRIM_THRESHOLD =
"pinot.broker.groupby.trim.threshold";
public static final int DEFAULT_BROKER_GROUPBY_TRIM_THRESHOLD = 1_000_000;
+ // Configure the request handler type used by broker to handler inbound
query request.
+ // NOTE: the request handler type refers to the communication between
Broker and Server.
+ public static final String BROKER_REQUEST_HANDLER_TYPE_JSON_OVERRIDE_KEY =
"handler.type";
public static final String BROKER_REQUEST_HANDLER_TYPE =
"pinot.broker.request.handler.type";
public static final String NETTY_BROKER_REQUEST_HANDLER_TYPE = "netty";
public static final String GRPC_BROKER_REQUEST_HANDLER_TYPE = "grpc";
+ public static final String MULTI_STAGE_BROKER_REQUEST_HANDLER_TYPE =
"multi_stage";
Review Comment:
Thinking more about this, I don't think a request handler specific config is
probably not needed for the multistage engine.
Our current goal is to have both the existing request handlers (GRPC and
Netty based) to be able to leverage the new engine as needed. Correct ?
So, then we just check the feature flag
(`CONFIG_OF_MULTI_STAGE_ENGINE_ENABLED`) config in `BaseBrokerStarter` (like
already being done in the PR) and create the multistage engine request handler
and put it under the delegate.
Now, the delegate uses the request specific key for the given query request
to determine which request handler to be invoked. So, I don't see us using this
config for now. Thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
