[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8720: Merge Multistage Engine back to main

[GitBox]

siddharthteotia commented on code in PR #8720:
URL: https://github.com/apache/pinot/pull/8720#discussion_r879811720


##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -251,24 +253,42 @@ public void start()
     TlsConfig tlsDefaults = TlsUtils.extractTlsConfig(_brokerConf, 
Broker.BROKER_TLS_PREFIX);
     NettyConfig nettyDefaults = NettyConfig.extractNettyConfig(_brokerConf, 
Broker.BROKER_NETTY_PREFIX);
 
-    if (_brokerConf.getProperty(Broker.BROKER_REQUEST_HANDLER_TYPE, 
Broker.DEFAULT_BROKER_REQUEST_HANDLER_TYPE)
-        .equalsIgnoreCase(Broker.GRPC_BROKER_REQUEST_HANDLER_TYPE)) {
+    // Create Broker request handler.
+    String brokerRequestHandlerType =
+        _brokerConf.getProperty(Broker.BROKER_REQUEST_HANDLER_TYPE, 
Broker.DEFAULT_BROKER_REQUEST_HANDLER_TYPE);
+    SingleConnectionBrokerRequestHandler nettyBrokerRequestHandler = null;
+    GrpcBrokerRequestHandler grpcBrokerRequestHandler = null;
+    if 
(brokerRequestHandlerType.equalsIgnoreCase(Broker.GRPC_BROKER_REQUEST_HANDLER_TYPE))
 {
       LOGGER.info("Starting Grpc BrokerRequestHandler.");
-      _brokerRequestHandler =
+      grpcBrokerRequestHandler =
           new GrpcBrokerRequestHandler(_brokerConf, _routingManager, 
_accessControlFactory, queryQuotaManager,
               tableCache, _brokerMetrics, null);
     } else { // default request handler type, e.g. netty
       LOGGER.info("Starting Netty BrokerRequestHandler.");
       if (_brokerConf.getProperty(Broker.BROKER_NETTYTLS_ENABLED, false)) {
-        _brokerRequestHandler =
+        nettyBrokerRequestHandler =
             new SingleConnectionBrokerRequestHandler(_brokerConf, 
_routingManager, _accessControlFactory,
                 queryQuotaManager, tableCache, _brokerMetrics, nettyDefaults, 
tlsDefaults);
       } else {
-        _brokerRequestHandler =
+        nettyBrokerRequestHandler =
             new SingleConnectionBrokerRequestHandler(_brokerConf, 
_routingManager, _accessControlFactory,
                 queryQuotaManager, tableCache, _brokerMetrics, nettyDefaults, 
null);
       }
     }
+
+    WorkerQueryRequestHandler multiStageQueryRequestHandler = null;
+    if (_brokerConf.getProperty(Helix.CONFIG_OF_MULTI_STAGE_ENGINE_ENABLED, 
Helix.DEFAULT_MULTI_STAGE_ENGINE_ENABLED)) {
+      LOGGER.info("Starting Multi-stage BrokerRequestHandler.");

Review Comment:
   May be we should move this log inside the start function in the delegate 
class ? Same for above 2 cases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org