siddharthteotia commented on code in PR #8720:
URL: https://github.com/apache/pinot/pull/8720#discussion_r879890015
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -172,6 +176,9 @@ public static class Instance {
public static final String CONFIG_OF_PINOT_BROKER_STARTABLE_CLASS =
"pinot.broker.startable.class";
public static final String CONFIG_OF_PINOT_SERVER_STARTABLE_CLASS =
"pinot.server.startable.class";
public static final String CONFIG_OF_PINOT_MINION_STARTABLE_CLASS =
"pinot.minion.startable.class";
+
+ public static final String CONFIG_OF_MULTI_STAGE_ENGINE_ENABLED =
"pinot.server.multi_stage.enabled";
Review Comment:
I wonder where should we specify this config. May be both broker and server
or a general config ?
The deployment / upgrade sequence is typically controller -> broker ->
server. I think our expectation is that user who wants to try this new feature
from master release will upgrade everything and then finally enable this config
followed by restart ? In that case may be a single config is fine.
But let's say broker is upgraded / new and this feature flag is set to true
but server is yet to be upgraded. What happens in this case if broker receives
a query that needs to be sent to multistage engine ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
