siddharthteotia commented on code in PR #8720: URL: https://github.com/apache/pinot/pull/8720#discussion_r879810457
########## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java: ########## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.broker.requesthandler; + +import com.fasterxml.jackson.databind.JsonNode; +import javax.annotation.Nullable; +import org.apache.pinot.broker.api.RequesterIdentity; +import org.apache.pinot.common.response.BrokerResponse; +import org.apache.pinot.spi.trace.RequestContext; +import org.apache.pinot.spi.utils.CommonConstants; + + +/** + * {@code BrokerRequestHandlerDelegate} delegates the inbound broker request to one of the enabled + * {@link BrokerRequestHandler} based on the requested handle type. + * + * {@see: @CommonConstant + */ +public class BrokerRequestHandlerDelegate implements BrokerRequestHandler { + + private String _defaultBrokerRequestHandlerType; + @Nullable + private SingleConnectionBrokerRequestHandler _singleConnectionBrokerRequestHandler; + @Nullable + private GrpcBrokerRequestHandler _grpcBrokerRequestHandler; + @Nullable + private WorkerQueryRequestHandler _multiStageWorkerRequestHandler; + + public BrokerRequestHandlerDelegate(@Nullable String defaultBrokerRequestHandlerType, + @Nullable SingleConnectionBrokerRequestHandler singleConnectionBrokerRequestHandler, + @Nullable GrpcBrokerRequestHandler grpcBrokerRequestHandler, + @Nullable WorkerQueryRequestHandler multiStageWorkerRequestHandler + ) { + _defaultBrokerRequestHandlerType = defaultBrokerRequestHandlerType != null ? defaultBrokerRequestHandlerType + : CommonConstants.Broker.DEFAULT_BROKER_REQUEST_HANDLER_TYPE; + _singleConnectionBrokerRequestHandler = singleConnectionBrokerRequestHandler; + _grpcBrokerRequestHandler = grpcBrokerRequestHandler; + _multiStageWorkerRequestHandler = multiStageWorkerRequestHandler; + } + + @Override + public void start() { + if (_singleConnectionBrokerRequestHandler != null) { + _singleConnectionBrokerRequestHandler.start(); + } + if (_grpcBrokerRequestHandler != null) { + _grpcBrokerRequestHandler.start(); + } + if (_multiStageWorkerRequestHandler != null) { + _multiStageWorkerRequestHandler.start(); + } + } + + @Override + public void shutDown() { + if (_singleConnectionBrokerRequestHandler != null) { + _singleConnectionBrokerRequestHandler.shutDown(); + } + if (_grpcBrokerRequestHandler != null) { + _grpcBrokerRequestHandler.shutDown(); + } + if (_multiStageWorkerRequestHandler != null) { + _multiStageWorkerRequestHandler.shutDown(); + } + } + + @Override + public BrokerResponse handleRequest(JsonNode request, @Nullable RequesterIdentity requesterIdentity, + RequestContext requestContext) + throws Exception { + JsonNode node = request.get(CommonConstants.Broker.BROKER_REQUEST_HANDLER_TYPE_JSON_OVERRIDE_KEY); + String handlerType = node == null ? _defaultBrokerRequestHandlerType : node.asText(); + switch (handlerType) { + case CommonConstants.Broker.NETTY_BROKER_REQUEST_HANDLER_TYPE: + if (_singleConnectionBrokerRequestHandler != null) { + return _singleConnectionBrokerRequestHandler.handleRequest(request, requesterIdentity, requestContext); + } else { + break; Review Comment: Throw exception here itself with the exact message something like - "requested for netty based request handler but it is not initialized". Same for remaining two cases ########## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/WorkerQueryRequestHandler.java: ########## @@ -0,0 +1,204 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.broker.requesthandler; + +import com.fasterxml.jackson.databind.JsonNode; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.concurrent.TimeUnit; +import javax.annotation.Nullable; +import org.apache.calcite.jdbc.CalciteSchemaBuilder; +import org.apache.commons.lang3.StringUtils; +import org.apache.pinot.broker.api.RequesterIdentity; +import org.apache.pinot.broker.broker.AccessControlFactory; +import org.apache.pinot.broker.queryquota.QueryQuotaManager; +import org.apache.pinot.broker.routing.BrokerRoutingManager; +import org.apache.pinot.common.config.TlsConfig; +import org.apache.pinot.common.config.provider.TableCache; +import org.apache.pinot.common.exception.QueryException; +import org.apache.pinot.common.metrics.BrokerMeter; +import org.apache.pinot.common.metrics.BrokerMetrics; +import org.apache.pinot.common.proto.Mailbox; +import org.apache.pinot.common.request.BrokerRequest; +import org.apache.pinot.common.response.broker.BrokerResponseNative; +import org.apache.pinot.common.response.broker.ResultTable; +import org.apache.pinot.common.utils.DataSchema; +import org.apache.pinot.common.utils.DataTable; +import org.apache.pinot.core.query.selection.SelectionOperatorUtils; +import org.apache.pinot.core.transport.ServerInstance; +import org.apache.pinot.query.QueryEnvironment; +import org.apache.pinot.query.catalog.PinotCatalog; +import org.apache.pinot.query.mailbox.GrpcMailboxService; +import org.apache.pinot.query.mailbox.MailboxService; +import org.apache.pinot.query.planner.QueryPlan; +import org.apache.pinot.query.routing.WorkerManager; +import org.apache.pinot.query.service.QueryConfig; +import org.apache.pinot.query.service.QueryDispatcher; +import org.apache.pinot.query.type.TypeFactory; +import org.apache.pinot.query.type.TypeSystem; +import org.apache.pinot.spi.env.PinotConfiguration; +import org.apache.pinot.spi.trace.RequestContext; +import org.apache.pinot.spi.utils.CommonConstants; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +public class WorkerQueryRequestHandler extends BaseBrokerRequestHandler { Review Comment: (nit) calling it MultiStageEngineRequestHandler might be better ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
