walterddr commented on code in PR #8720:
URL: https://github.com/apache/pinot/pull/8720#discussion_r879959292
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -172,6 +176,9 @@ public static class Instance {
public static final String CONFIG_OF_PINOT_BROKER_STARTABLE_CLASS =
"pinot.broker.startable.class";
public static final String CONFIG_OF_PINOT_SERVER_STARTABLE_CLASS =
"pinot.server.startable.class";
public static final String CONFIG_OF_PINOT_MINION_STARTABLE_CLASS =
"pinot.minion.startable.class";
+
+ public static final String CONFIG_OF_MULTI_STAGE_ENGINE_ENABLED =
"pinot.server.multi_stage.enabled";
Review Comment:
the key is that both broker and server should shared the same
`pinot.multistage.engine.enabled` config key (one config is enough).
in the situation of upgrade, if broker is enabled but server is not (e.g.
not yet upgraded) then broker query planner (QueryEnvironment class) cannot
generate a runnable query plan, because it cannot assign segments/tableScan to
the appropriate servers.
this is because, when multi-stage query engine on server is enabled; a
`multi-stage.query.request.port` and `multi-stage.query.mailbox.port` is
configured and registered in Zookeeper associated with the `ServerInstance`
ZNode. if those ports are -1, broker cannot use them for runnable plan
generation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
