walterddr commented on code in PR #8720:
URL: https://github.com/apache/pinot/pull/8720#discussion_r879960768
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -218,11 +225,16 @@ public static class Broker {
public static final String CONFIG_OF_BROKER_GROUPBY_TRIM_THRESHOLD =
"pinot.broker.groupby.trim.threshold";
public static final int DEFAULT_BROKER_GROUPBY_TRIM_THRESHOLD = 1_000_000;
+ // Configure the request handler type used by broker to handler inbound
query request.
+ // NOTE: the request handler type refers to the communication between
Broker and Server.
+ public static final String BROKER_REQUEST_HANDLER_TYPE_JSON_OVERRIDE_KEY =
"handler.type";
public static final String BROKER_REQUEST_HANDLER_TYPE =
"pinot.broker.request.handler.type";
public static final String NETTY_BROKER_REQUEST_HANDLER_TYPE = "netty";
public static final String GRPC_BROKER_REQUEST_HANDLER_TYPE = "grpc";
+ public static final String MULTI_STAGE_BROKER_REQUEST_HANDLER_TYPE =
"multi_stage";
Review Comment:
the reason is `multi-stage` is yet another handler type as we defined in
previous `RequestHandler` concrete class. also we have the `OVERRIDE_KEY`
configuration in JSON payload from the request itself.
If we opted to use a boolean flag like `use.multistage.engine=true` in the
JSON payload then we don't need this . I am open to either route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
