saurabhd336 commented on code in PR #8601:
URL: https://github.com/apache/pinot/pull/8601#discussion_r875595044
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -134,6 +139,20 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
invertedIndexColumns.add(columnName);
}
+ Set<String> bloomFilterColumns = new HashSet<>();
+ for (String columnName : _config.getBloomFilterCreationColumns()) {
+ Preconditions.checkState(schema.hasColumn(columnName),
+ "Cannot create bloom filter for column: %s because it is not in
schema", columnName);
+ bloomFilterColumns.add(columnName);
+ }
+
+ Set<String> rangeIndexColumns = new HashSet<>();
+ for (String columnName : _config.getRangeIndexCreationColumns()) {
+ Preconditions.checkState(schema.hasColumn(columnName),
+ "Cannot create bloom filter for column: %s because it is not in
schema", columnName);
Review Comment:
Ack
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -89,6 +92,8 @@ public class SegmentColumnarIndexCreator implements
SegmentCreator {
private SegmentGeneratorConfig _config;
private Map<String, ColumnIndexCreationInfo> _indexCreationInfoMap;
private final IndexCreatorProvider _indexCreatorProvider =
IndexingOverrides.getIndexCreatorProvider();
+ private final Map<String, BloomFilterCreator> _bloomFilterCreatorMap = new
HashMap<>();
+ private final Map<String, CombinedInvertedIndexCreator>
_rangeIndexFilterCreatorMap = new HashMap<>();
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
