Jackie-Jiang commented on code in PR #8601:
URL: https://github.com/apache/pinot/pull/8601#discussion_r863044298
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##########
@@ -64,6 +64,7 @@ public class IndexingConfig extends BaseJsonConfig {
// TODO: Add a new configuration related to the segment generation
private boolean _autoGeneratedInvertedIndex;
private boolean _createInvertedIndexDuringSegmentGeneration;
+ private boolean _createBloomFilterDuringSegmentGeneration;
Review Comment:
My suggestion is to not add a flag in this PR and always create the bloom
filter index + range index if they are configured. It does change the current
behavior, but that is the desired behavior and we don't want to complicate the
config in this PR. The only exception we have right now is inverted index, and
we should think of a migration plan for it in a separate thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
