Jackie-Jiang commented on code in PR #8601:
URL: https://github.com/apache/pinot/pull/8601#discussion_r864267277
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##########
@@ -64,6 +64,7 @@ public class IndexingConfig extends BaseJsonConfig {
// TODO: Add a new configuration related to the segment generation
private boolean _autoGeneratedInvertedIndex;
private boolean _createInvertedIndexDuringSegmentGeneration;
+ private boolean _createBloomFilterDuringSegmentGeneration;
Review Comment:
I wouldn't call it backward-incompatible though. When we add a new index
type, we always create them during segment creation if configured (e.g. text,
fst, json, h3, null-vector), and inverted index is the only exception here. We
don't create index for range and bloom filter right now is because we missed
this part when adding the feature.
In the long term, we want to add a separate config to configure which index
types to create during segment creation, and by default we should generate all
indexes (deprecate the `createInvertedIndexDuringSegmentGeneration`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
