saurabhd336 commented on code in PR #8601: URL: https://github.com/apache/pinot/pull/8601#discussion_r861771379
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java: ########## @@ -64,6 +64,7 @@ public class IndexingConfig extends BaseJsonConfig { // TODO: Add a new configuration related to the segment generation private boolean _autoGeneratedInvertedIndex; private boolean _createInvertedIndexDuringSegmentGeneration; + private boolean _createBloomFilterDuringSegmentGeneration; Review Comment: Ack. This flag will be replaced with "createAllIndexesDuringSegmentGeneration". Just to be clear, as discussed with @npawar , For the first part of this change, we'd be introducing a "createAllIndexesDuringSegmentGeneration" flag. If that is set as true, we'd create all indexes during segment creation. If its set to false, we'll only maintain status quo, and create only the indexes that we already create. Are we aligned on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org