saurabhd336 commented on code in PR #8601:
URL: https://github.com/apache/pinot/pull/8601#discussion_r876657908
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -215,6 +237,22 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
dictionaryCreator.getNumBytesPerEntry());
throw e;
}
+
+ if (bloomFilterColumns.contains(columnName)) {
Review Comment:
Agreed that it'll work if we just move it outside the if block, but I had
intentionally put it there to ensure the behaviour remains consistent across
offline segment creation, and when bloomFilter is being build during segment
loading. Anyway, I've moved it out, and raised a new issue
https://github.com/apache/pinot/issues/8735.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
