Jackie-Jiang commented on code in PR #8601:
URL: https://github.com/apache/pinot/pull/8601#discussion_r876403984
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -215,6 +237,22 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
dictionaryCreator.getNumBytesPerEntry());
throw e;
}
+
+ if (bloomFilterColumns.contains(columnName)) {
Review Comment:
From the segment creator side, we can support bloom filter with/without
dictionary because we use values to create the bloom filter instead of the dict
ids. We don't support bloom filter on raw index currently because the handler
side support is not implemented. Let's create an issue to add support on the
handler side. Here we can move this outside of the if check, which should just
work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
