Jackie-Jiang commented on a change in pull request #6719:
URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r618671632
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java
##########
@@ -737,11 +732,11 @@ public static void
removeColumnMetadataInfo(PropertiesConfiguration properties,
* @return raw index creator
* @throws IOException
*/
- public static ForwardIndexCreator getRawIndexCreatorForColumn(File file,
- ChunkCompressionType compressionType, String column, DataType dataType,
int totalDocs,
- int lengthOfLongestEntry, boolean deriveNumDocsPerChunk, int
writerVersion)
+ public static ForwardIndexCreator getRawIndexCreatorForColumn(File file,
ChunkCompressionType compressionType,
+ String column, DataType dataType, int totalDocs, int
lengthOfLongestEntry, boolean deriveNumDocsPerChunk,
+ int writerVersion)
throws IOException {
- switch (dataType) {
+ switch (dataType.getStoredType()) {
Review comment:
Added some comments in the javadoc of `DataType.getStoredType()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
