Jackie-Jiang commented on a change in pull request #6719:
URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r614546131
##########
File path:
pinot-common/src/test/java/org/apache/pinot/common/data/DateTimeFormatSpecTest.java
##########
@@ -82,6 +86,8 @@ public void testFromMillisToFormat(String format, long
timeMs, String expectedFo
entries.add(new Object[]{"1:MILLISECONDS:EPOCH", 1498892400000L,
"1498892400000"});
entries.add(new Object[]{"1:HOURS:EPOCH", 0L, "0"});
entries.add(new Object[]{"5:MINUTES:EPOCH", 1498892400000L, "4996308"});
+ entries.add(new Object[]{"1:MILLISECONDS:TIMESTAMP", Timestamp
Review comment:
SQL Timestamp always have values in `yyyy-MM-dd HH:mm:ss.SSS` format,
and it doesn't allow `nanoseconds` granularity. The first 2 values are actually
ignored (similar to date time format which only reads the 4th argument as the
format). We should consider changing the order for these arguments for clarity,
but that is out of the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
