Jackie-Jiang commented on a change in pull request #6719:
URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r614491082
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -375,6 +530,16 @@ public double toDouble(Object value) {
throw new UnsupportedOperationException("Cannot convert value from BYTES
to DOUBLE");
}
+ @Override
+ public boolean toBoolean(Object value) {
+ throw new UnsupportedOperationException("Cannot convert value from BYTES
to BOOLEAN");
Review comment:
I wouldn't worry too much about that. People are not supposed to use
`BYTES` as `BOOLEAN`, and throwing exception might be a safer option to avoid
unexpected behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
