Jackie-Jiang commented on a change in pull request #6719:
URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r618864831
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java
##########
@@ -215,7 +236,34 @@ public int hashCode() {
}
public enum ColumnDataType {
- INT, LONG, FLOAT, DOUBLE, STRING, BYTES, OBJECT, INT_ARRAY, LONG_ARRAY,
FLOAT_ARRAY, DOUBLE_ARRAY, STRING_ARRAY;
+ INT,
+ LONG,
+ FLOAT,
+ DOUBLE,
+ BOOLEAN /* Stored as INT */,
Review comment:
Probably no. It doesn't make sense to add them as logical types and
backed by int because that won't save any storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
