Jackie-Jiang commented on a change in pull request #6719:
URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r614546866
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -775,6 +969,18 @@ public static PinotDataType
getPinotDataTypeForIngestion(FieldSpec fieldSpec) {
return fieldSpec.isSingleValueField() ? PinotDataType.FLOAT :
PinotDataType.FLOAT_ARRAY;
case DOUBLE:
return fieldSpec.isSingleValueField() ? PinotDataType.DOUBLE :
PinotDataType.DOUBLE_ARRAY;
+ case BOOLEAN:
+ if (fieldSpec.isSingleValueField()) {
+ return PinotDataType.BOOLEAN;
+ } else {
+ throw new IllegalStateException("There is no multi-value type for
BOOLEAN");
+ }
+ case TIMESTAMP:
+ if (fieldSpec.isSingleValueField()) {
+ return PinotDataType.TIMESTAMP;
+ } else {
+ throw new IllegalStateException("There is no multi-value type for
TIMESTAMP");
Review comment:
`TIMESTAMP` is mostly used as the time field, which does not allow MV.
If required, we can add the support later. Added a todo here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
