Jackie-Jiang commented on a change in pull request #6719:
URL: https://github.com/apache/incubator-pinot/pull/6719#discussion_r614498498
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/EqualsPredicateEvaluatorFactory.java
##########
@@ -54,30 +57,36 @@ public static BaseDictionaryBasedPredicateEvaluator
newDictionaryBasedEvaluator(
*/
public static BaseRawValueBasedPredicateEvaluator
newRawValueBasedEvaluator(EqPredicate eqPredicate,
DataType dataType) {
+ String value = eqPredicate.getValue();
switch (dataType) {
case INT:
- return new IntRawValueBasedEqPredicateEvaluator(eqPredicate);
+ return new
IntRawValueBasedEqPredicateEvaluator(Integer.parseInt(value));
Review comment:
Yes, because `BOOLEAN` and `TIMESTAMP` is stored as another type, making
these changes so that the code can be reused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
