suvodeep-pyne commented on code in PR #17099:
URL: https://github.com/apache/pinot/pull/17099#discussion_r2482412777
##########
pinot-server/src/test/java/org/apache/pinot/server/api/BaseResourceTest.java:
##########
@@ -157,7 +158,9 @@ public void setUp()
CommonConstants.Helix.DEFAULT_SERVER_NETTY_PORT);
_instanceId = CommonConstants.Helix.PREFIX_OF_SERVER_INSTANCE + hostname +
"_" + port;
serverConf.setProperty(CommonConstants.Server.CONFIG_OF_INSTANCE_ID,
_instanceId);
- _adminApiApplication = new AdminApiApplication(_serverInstance, new
AllowAllAccessFactory(), serverConf);
+ _adminApiApplication = new AdminApiApplication(_serverInstance, new
AllowAllAccessFactory(),
+ mock(ServerReloadJobStatusCache.class),
Review Comment:
great point. the
`org.apache.pinot.core.data.manager.provider.TableDataManagerProvider#getTableDataManager(org.apache.pinot.spi.config.table.TableConfig,
org.apache.pinot.spi.data.Schema)` method actually initializes the cache. This
is used in a few tests.
<img width="776" height="364" alt="Screenshot 2025-10-31 at 11 57 56 AM"
src="https://github.com/user-attachments/assets/079e3e42-2c7d-4e30-ab0a-abb5cbc34c07";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
