suvodeep-pyne commented on code in PR #17099:
URL: https://github.com/apache/pinot/pull/17099#discussion_r2482355697
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentReloadStatusValue.java:
##########
@@ -22,10 +22,16 @@
public class SegmentReloadStatusValue {
private final long _totalSegmentCount;
private final long _successCount;
+ private final Long _failureCount;
Review Comment:
So, this is a DTO object (API response) and I'd rather have the json
response not include failure counts if not applicable/populated vs sending a
`-1L` value while summing them up later. The performance arg is valid but
probably negligible here given that we are storing 1 Long object per job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
