suvodeep-pyne commented on code in PR #17099:
URL: https://github.com/apache/pinot/pull/17099#discussion_r2482400937
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/InstanceDataManager.java:
##########
@@ -117,19 +118,19 @@ void deleteSegment(String tableNameWithType, String
segmentName)
* Download happens when local segment's CRC mismatches the one of the
remote segment; but can also be forced to do
* regardless of CRC.
*/
- void reloadSegment(String tableNameWithType, String segmentName, boolean
forceDownload)
+ void reloadSegment(String tableNameWithType, String segmentName, boolean
forceDownload, String reloadJobId)
throws Exception;
/**
* Reloads all segments of a table.
*/
- void reloadAllSegments(String tableNameWithType, boolean forceDownload)
+ void reloadAllSegments(String tableNameWithType, boolean forceDownload,
String reloadJobId)
throws Exception;
/**
* Reload a list of segments in a table.
*/
- void reloadSegments(String tableNameWithType, List<String> segmentNames,
boolean forceDownload)
+ void reloadSegments(String tableNameWithType, List<String> segmentNames,
boolean forceDownload, String reloadJobId)
Review Comment:
I actually thought about this. I decided to not add more overloaded methods
to already 3 methods here. Instead, the refactor plan that i have in mind is to
have a `ReloadJobRequest` object or similar that can host different variants of
reload. It may be easier to have a container consolidating all 3 methods +
providing room to add parameters easily for more options/extensibility going
forward.
But I did not want to tackle that refactor in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
