suvodeep-pyne commented on code in PR #17099:
URL: https://github.com/apache/pinot/pull/17099#discussion_r2482358807
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/ControllerJobStatusResource.java:
##########
@@ -44,18 +47,28 @@
@Api(tags = "Tasks")
@Path("/")
+@Singleton
public class ControllerJobStatusResource {
+ private final ServerInstance _serverInstance;
+ private final ServerReloadJobStatusCache _serverReloadJobStatusCache;
+
@Inject
- private ServerInstance _serverInstance;
+ public ControllerJobStatusResource(ServerInstance serverInstance,
+ ServerReloadJobStatusCache serverReloadJobStatusCache) {
+ _serverInstance = serverInstance;
+ _serverReloadJobStatusCache = serverReloadJobStatusCache;
+ }
@GET
@Path("/controllerJob/reloadStatus/{tableNameWithType}")
@Produces(MediaType.APPLICATION_JSON)
@ApiOperation(value = "Task status", notes = "Return the status of a given
reload job")
public String reloadJobStatus(@PathParam("tableNameWithType") String
tableNameWithType,
@QueryParam("reloadJobTimestamp") long reloadJobSubmissionTimestamp,
- @QueryParam("segmentName") String segmentName, @Context HttpHeaders
headers)
+ @QueryParam("segmentName") String segmentName,
+ @QueryParam("reloadJobId") String reloadJobId,
Review Comment:
yes. no logic change for existing code in this PR.
If reloadJob id is provided --> check failure counts and add them in the
response. else old behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
