suvodeep-pyne commented on code in PR #17099:
URL: https://github.com/apache/pinot/pull/17099#discussion_r2488124495
##########
pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkDimensionTableOverhead.java:
##########
@@ -186,9 +187,18 @@ public DimensionTableDataManager benchmark()
String tableName = TABLE_NAME + "_" + _iteration;
_tableDataManager =
DimensionTableDataManager.createInstanceByTableName(tableName);
- _tableDataManager.init(instanceDataManagerConfig, helixManager, new
SegmentLocks(), tableConfig, SCHEMA,
- new SegmentReloadSemaphore(1), Executors.newSingleThreadExecutor(),
null, null, SEGMENT_OPERATIONS_THROTTLER,
- false);
+ _tableDataManager.init(instanceDataManagerConfig,
Review Comment:
I think I did this in a couple of cases in this PR on purpose. It was just
getting hard to count/read 10+ args fn calls with multiple nulls etc. so chose
to chop it down.
understand the nit and the pain of reviewing a PR of this size. Will try to
avoid. There are no changes other than adding the cache manager arg to the
chain. I'd ideally like to get this in to make some progress on the next part
if that is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
