suvodeep-pyne commented on code in PR #17099: URL: https://github.com/apache/pinot/pull/17099#discussion_r2482333412
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/ServerReloadJobStatusCache.java: ########## @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.utils; + +import com.google.common.cache.Cache; +import com.google.common.cache.CacheBuilder; +import java.util.concurrent.TimeUnit; +import javax.annotation.Nullable; +import javax.annotation.concurrent.ThreadSafe; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static java.util.Objects.requireNonNull; + + +/** + * In-memory cache for tracking reload job status on server side. + * Phase 1: Only tracks failure count per job. + * + * <p>Thread-safe for concurrent access. Uses Guava Cache with LRU eviction + * and time-based expiration. + */ +@ThreadSafe +public class ServerReloadJobStatusCache { + private static final Logger LOG = LoggerFactory.getLogger(ServerReloadJobStatusCache.class); + + private final Cache<String, ReloadJobStatus> _cache; + + /** + * Creates a cache with the given configuration. + * + */ + public ServerReloadJobStatusCache() { + final ServerReloadJobStatusCacheConfig config = new ServerReloadJobStatusCacheConfig(); Review Comment: This currently should not be an issue given that we are only storing `failureCounts` (`long`) per reload job. and since # of jobs ~ # of tables, there is no practical memory implication for it. the cache is like a stub at this point. As we introduce larger objects to the cache, it may need configuration as well as possibly management level APIs to clean up, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
