Desdroid commented on code in PR #65006:
URL: https://github.com/apache/airflow/pull/65006#discussion_r3071439051
##########
helm-tests/tests/helm_tests/other/test_redis.py:
##########
@@ -82,14 +84,17 @@ def assert_password_and_broker_url_secrets(
assert REDIS_OBJECTS["SECRET_BROKER_URL"] not in
k8s_obj_by_key.keys()
def assert_broker_url_env(
- self, k8s_obj_by_key,
expected_broker_url_secret_name=REDIS_OBJECTS["SECRET_BROKER_URL"][1]
+ self,
+ k8s_obj_by_key,
+ expected_broker_url_secret_name=REDIS_OBJECTS["SECRET_BROKER_URL"][1],
+ airflow_fullname: str = RELEASE_NAME_REDIS,
):
broker_url_secret_in_scheduler =
self.get_broker_url_secret_in_deployment(
- k8s_obj_by_key, "StatefulSet", "worker"
+ k8s_obj_by_key, "StatefulSet", "worker", airflow_fullname
)
assert broker_url_secret_in_scheduler ==
expected_broker_url_secret_name
broker_url_secret_in_worker = self.get_broker_url_secret_in_deployment(
- k8s_obj_by_key, "Deployment", "scheduler"
+ k8s_obj_by_key, "Deployment", "scheduler", airflow_fullname
)
assert broker_url_secret_in_worker == expected_broker_url_secret_name
Review Comment:
Not caused by my code change, but fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
