Miretpl commented on code in PR #65006:
URL: https://github.com/apache/airflow/pull/65006#discussion_r3067836786
##########
chart/templates/_helpers.yaml:
##########
@@ -122,7 +122,7 @@ If release name contains chart name it will be used as a
full name.
- name: AIRFLOW__CELERY__BROKER_URL
valueFrom:
secretKeyRef:
- name: {{ default (printf "%s-broker-url" .Release.Name)
.Values.data.brokerUrlSecretName }}
+ name: {{ default (printf "%s-broker-url" (include "airflow.fullname"
.)) .Values.data.brokerUrlSecretName }}
Review Comment:
I was thinking more about the name matches test between the given secret and
the environment variable. I think that this issue is not chart dependency
specific, but is affecting any setup where `.Relase.Name != airflow.fullname`
which is possible to do by using different configuration options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
