Miretpl commented on PR #65006: URL: https://github.com/apache/airflow/pull/65006#issuecomment-4224746295
> This PR was only in the Bug Fixes section and no migration hint provided but effectively leads to renaming a bunch of k8s resources which helm does not automatically migrate or doesn't support changing. E.g. it seems like the serviceName of the Triggerer StatefulSet was also changed, which I think is not supported by helm. We then get Error: UPGRADE FAILED: cannot patch "pipelines-airflow-triggerer" with kind StatefulSet: StatefulSet.apps "pipelines-airflow-triggerer" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordinals', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden trying to do a simple helm upgrade. I think it was just missed before the release that it can, potentially, break some stuff. Sorry for the inconvenience and thanks for the PR! > While I think this is a bit of an edge case (Having the helm chart of airflow as a dependency) - should I add some Info in the docs? Or the GH Releases notes be adapted? What do you think? I think some extension to the `extending-the-chart.rst` would be good to add, and maybe a newsfragment to make this bugfix more visible during the next release, as it changes the behaviour, and I would not be surprised if some people are depending on the current behaviour even if they do not know about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
