Desdroid commented on code in PR #65006:
URL: https://github.com/apache/airflow/pull/65006#discussion_r3065576682
##########
chart/templates/_helpers.yaml:
##########
@@ -122,7 +122,7 @@ If release name contains chart name it will be used as a
full name.
- name: AIRFLOW__CELERY__BROKER_URL
valueFrom:
secretKeyRef:
- name: {{ default (printf "%s-broker-url" .Release.Name)
.Values.data.brokerUrlSecretName }}
+ name: {{ default (printf "%s-broker-url" (include "airflow.fullname"
.)) .Values.data.brokerUrlSecretName }}
Review Comment:
There are no tests for using the chart as a dependency. However this bug has
2 prerequisites:
`useStandardNaming: true` and having ``fullnameOverride != Release.Name``,
``nameOverride != Release.Name`` or use the airflow helm chart as a dependency.
So i added a test for the fullnameOverride case. If you want a different
test case, let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
